<html>
<head><meta charset="utf-8"><title>fix the error trait PR finalization · project-error-handling · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/index.html">project-error-handling</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html">fix the error trait PR finalization</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="219381267"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219381267" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219381267">(Dec 09 2020 at 18:56)</a>:</h4>
<p><span class="user-mention" data-user-id="281739">@oliver</span> , wrt the fix the error trai tPR</p>



<a name="219381326"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219381326" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219381326">(Dec 09 2020 at 18:56)</a>:</h4>
<p>I checked it out and I think there are a few more steps we need to complete before final review can start</p>



<a name="219381439"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219381439" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219381439">(Dec 09 2020 at 18:57)</a>:</h4>
<p>most of them are already in progress, aka <span class="user-mention" data-user-id="204346">@Ashley Mannix</span> fixing the fmt repr inconsistencies in the panic output and <span class="user-mention" data-user-id="344196">@Jakub Duchniewicz</span> fixing merge conflicts</p>



<a name="219381531"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219381531" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219381531">(Dec 09 2020 at 18:58)</a>:</h4>
<p>there is one bit where I think we need to update the PR, it still has a bullet item for the backtrace precision</p>



<a name="219381558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219381558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219381558">(Dec 09 2020 at 18:58)</a>:</h4>
<p>but the consensus from the issue it links to is that we shouldn't block stabilization on that feature request</p>



<a name="219381573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219381573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219381573">(Dec 09 2020 at 18:58)</a>:</h4>
<p>so I think we should remove that bullet from the issue</p>



<a name="219381611"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219381611" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219381611">(Dec 09 2020 at 18:58)</a>:</h4>
<p><span class="user-mention" data-user-id="204346">@Ashley Mannix</span> do you know how I'd go about getting that bullet removed?</p>



<a name="219381630"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219381630" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219381630">(Dec 09 2020 at 18:58)</a>:</h4>
<p>I'm planning on attending the libs meeting today, should I bring that up?</p>



<a name="219395744"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219395744" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219395744">(Dec 09 2020 at 20:50)</a>:</h4>
<p>thanks for making this a separate topic!</p>



<a name="219396720"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219396720" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219396720">(Dec 09 2020 at 20:58)</a>:</h4>
<p>I'm looking forward to wrapping up this task</p>



<a name="219549971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219549971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219549971">(Dec 10 2020 at 23:49)</a>:</h4>
<p>my pleasure</p>



<a name="219549999"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219549999" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219549999">(Dec 10 2020 at 23:49)</a>:</h4>
<p>just a quick update, I talked with the libs team a bit yesterday and I think we have a good idea of what we need to do to move forward</p>



<a name="219550073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219550073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219550073">(Dec 10 2020 at 23:50)</a>:</h4>
<p>we're gonna finish the fmt change PR, resolve merge conflicts, remove the precision flag bullet, and then we write the stabilization report and do any doc updates necessary</p>



<a name="219550096"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/219550096" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#219550096">(Dec 10 2020 at 23:50)</a>:</h4>
<p>pretty much confirming the plan from above</p>



<a name="221394427"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221394427" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221394427">(Jan 02 2021 at 10:42)</a>:</h4>
<p>Hey, just jumping in to tell I will do the merge before our next meeting. Holiday season got pretty time-consuming :)</p>



<a name="221396136"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221396136" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221396136">(Jan 02 2021 at 11:35)</a>:</h4>
<p>Just curious if this is alright if I push merge changes to withoutboats' feature branch (this will trigger GH update to the PR)?</p>



<a name="221396311"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221396311" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221396311">(Jan 02 2021 at 11:40)</a>:</h4>
<p>maybe I am wrong, but the only way  I see this can work is to make a PR to withoutboats' repository and then they accept it and the PR on the main rust repo is updated with the changes</p>



<a name="221396315"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221396315" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221396315">(Jan 02 2021 at 11:40)</a>:</h4>
<p>difficult git stuff <span aria-label="stuck out tongue" class="emoji emoji-1f61b" role="img" title="stuck out tongue">:stuck_out_tongue:</span></p>



<a name="221399526"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221399526" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221399526">(Jan 02 2021 at 13:10)</a>:</h4>
<p>Ok I figured some other way</p>



<a name="221399581"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221399581" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221399581">(Jan 02 2021 at 13:12)</a>:</h4>
<p>I added withoutboats' as a remote and tried rebasing it onto current master and then added the necessary changes (as the files have moved around the directories)</p>



<a name="221399582"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221399582" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221399582">(Jan 02 2021 at 13:12)</a>:</h4>
<p>dunno if this is proper</p>



<a name="221399711"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221399711" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221399711">(Jan 02 2021 at 13:16)</a>:</h4>
<p>however I as soon as I rebase boats' branch onto new master I get info that remote is diverged from local branch</p>



<a name="221399722"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221399722" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221399722">(Jan 02 2021 at 13:17)</a>:</h4>
<p>I think I need a hand in here <span aria-label="frown" class="emoji emoji-1f641" role="img" title="frown">:frown:</span></p>



<a name="221399773"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221399773" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221399773">(Jan 02 2021 at 13:18)</a>:</h4>
<p>all I need to do is rebase their branch onto the master branch and add the necessary merge fixes and push the commit to boats' repo</p>



<a name="221399774"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221399774" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221399774">(Jan 02 2021 at 13:18)</a>:</h4>
<p>this will update the PR</p>



<a name="221402203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221402203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221402203">(Jan 02 2021 at 14:31)</a>:</h4>
<p><span class="user-mention silent" data-user-id="344196">Jakub Duchniewicz</span> <a href="#narrow/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization/near/221399711">said</a>:</p>
<blockquote>
<p>however I as soon as I rebase boats' branch onto new master I get info that remote is diverged from local branch</p>
</blockquote>
<p>that's how rebasing works, every time you rebase you need to force-push</p>



<a name="221404627"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221404627" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221404627">(Jan 02 2021 at 15:43)</a>:</h4>
<p><span class="user-mention" data-user-id="344196">@Jakub Duchniewicz</span> what kind of errors are you seeing?</p>



<a name="221415861"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221415861" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221415861">(Jan 02 2021 at 20:26)</a>:</h4>
<p>right (always afraid of force-pushing <span aria-label="smiley" class="emoji emoji-1f603" role="img" title="smiley">:smiley:</span> )</p>



<a name="221415870"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221415870" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221415870">(Jan 02 2021 at 20:26)</a>:</h4>
<p>I tried commiting just now and got a problem on x.py script updating submodules</p>



<a name="221415880"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221415880" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221415880">(Jan 02 2021 at 20:27)</a>:</h4>
<div class="codehilite"><pre><span></span><code>Running pre-commit script &#39;/mnt/games/Projects/rust/x.py test tidy --bless&#39;
Updating only changed submodules
Updating submodule src/doc/nomicon
Submodule path &#39;src/doc/nomicon&#39;: checked out &#39;a5a48441d411f61556b57d762b03d6874afe575d&#39;
fatal: .git/index: index file open failed: Not a directory
failed to run: git reset -q --hard
</code></pre></div>



<a name="221415965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221415965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221415965">(Jan 02 2021 at 20:29)</a>:</h4>
<p><span class="user-mention" data-user-id="344196">@Jakub Duchniewicz</span> <a href="https://github.com/rust-lang/rust/issues/77620">https://github.com/rust-lang/rust/issues/77620</a></p>



<a name="221415969"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221415969" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221415969">(Jan 02 2021 at 20:29)</a>:</h4>
<p>or at least it looks similar</p>



<a name="221415972"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221415972" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221415972">(Jan 02 2021 at 20:29)</a>:</h4>
<p>the fix is to unset GIT_DIR in the precommit script</p>



<a name="221416174"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221416174" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221416174">(Jan 02 2021 at 20:34)</a>:</h4>
<p>hmm it seems like it is already this way</p>



<a name="221420585"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/221420585" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> scottmcm <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#221420585">(Jan 02 2021 at 22:23)</a>:</h4>
<p><span class="user-mention silent" data-user-id="344196">Jakub Duchniewicz</span> <a href="#narrow/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization/near/221415861">said</a>:</p>
<blockquote>
<p>right (always afraid of force-pushing <span aria-label="smiley" class="emoji emoji-1f603" role="img" title="smiley">:smiley:</span> )</p>
</blockquote>
<p>The good news of force pushing is that github now tracks them, so you can get back the old commits if needed.</p>



<a name="222066583"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222066583" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222066583">(Jan 08 2021 at 12:27)</a>:</h4>
<p>Ok I found out the problem was with submodules</p>



<a name="222066608"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222066608" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222066608">(Jan 08 2021 at 12:27)</a>:</h4>
<p>after running <code>git submodule update</code> I managed to do the commi</p>



<a name="222066621"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222066621" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222066621">(Jan 08 2021 at 12:27)</a>:</h4>
<p>only problem is that I have no write access rights to boats' repo</p>



<a name="222066663"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222066663" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222066663">(Jan 08 2021 at 12:28)</a>:</h4>
<p>not sure how to approach that though</p>



<a name="222066695"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222066695" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222066695">(Jan 08 2021 at 12:28)</a>:</h4>
<p><span class="user-mention" data-user-id="220273">@Jane Lusby</span> ping to make sure I am doing everything properly <span aria-label="smile" class="emoji emoji-1f642" role="img" title="smile">:smile:</span></p>



<a name="222136979"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222136979" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222136979">(Jan 08 2021 at 23:00)</a>:</h4>
<p>yea, that sounds about right</p>



<a name="222136988"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222136988" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222136988">(Jan 08 2021 at 23:00)</a>:</h4>
<p>let me start with finishing getting you added to the rust organization on github</p>



<a name="222136999"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222136999" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222136999">(Jan 08 2021 at 23:00)</a>:</h4>
<p>because that might make a difference, unsure</p>



<a name="222137871"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222137871" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222137871">(Jan 08 2021 at 23:10)</a>:</h4>
<p><span class="user-mention" data-user-id="344196">@Jakub Duchniewicz</span> have you pushed the fixed branch to your fork?</p>



<a name="222137884"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222137884" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222137884">(Jan 08 2021 at 23:11)</a>:</h4>
<p>I don't see it in <a href="https://github.com/JDuchniewicz/rust/branches">https://github.com/JDuchniewicz/rust/branches</a></p>



<a name="222137901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222137901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222137901">(Jan 08 2021 at 23:11)</a>:</h4>
<p>gonna try attacking this from multiple angles</p>



<a name="222137920"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222137920" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222137920">(Jan 08 2021 at 23:11)</a>:</h4>
<p>while I wait for the team updates to land I'm gonna see if I can just get boats to reset their branch to yours</p>



<a name="222147752"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147752" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Ellis O&#x27;Riley Jr. <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147752">(Jan 09 2021 at 02:05)</a>:</h4>
<p>Did you receive my feedback?  I just noticed the invite email</p>



<a name="222147772"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147772" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147772">(Jan 09 2021 at 02:05)</a>:</h4>
<p>your feedback?</p>



<a name="222147775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147775">(Jan 09 2021 at 02:06)</a>:</h4>
<p>I'm not sure</p>



<a name="222147812"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147812" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147812">(Jan 09 2021 at 02:06)</a>:</h4>
<p>in zulip?</p>



<a name="222147834"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147834" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Ellis O&#x27;Riley Jr. <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147834">(Jan 09 2021 at 02:06)</a>:</h4>
<p>Wrong word.  Sorry. I responded to the email I received, invite, to rust-lang.</p>



<a name="222147837"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147837" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147837">(Jan 09 2021 at 02:07)</a>:</h4>
<p>ah!</p>



<a name="222147840"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147840" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147840">(Jan 09 2021 at 02:07)</a>:</h4>
<p>excellent</p>



<a name="222147853"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147853" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147853">(Jan 09 2021 at 02:07)</a>:</h4>
<p>you should receive notifications now when we get pinged in github</p>



<a name="222147865"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147865" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Ellis O&#x27;Riley Jr. <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147865">(Jan 09 2021 at 02:07)</a>:</h4>
<p>Cool.</p>



<a name="222147875"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147875" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147875">(Jan 09 2021 at 02:07)</a>:</h4>
<p>The invite email is automated; it's sent a bit after the PR to rust-lang/team is merged.</p>



<a name="222147917"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147917" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Ellis O&#x27;Riley Jr. <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147917">(Jan 09 2021 at 02:08)</a>:</h4>
<p>What's with the 2 part authentication?</p>



<a name="222147943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Noah Lev <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147943">(Jan 09 2021 at 02:09)</a>:</h4>
<p>It's a security measure – you can ask in <a class="stream" data-stream-id="242791" href="/#narrow/stream/242791-t-infra">#t-infra</a> if you want to learn more.</p>



<a name="222147952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222147952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Ellis O&#x27;Riley Jr. <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222147952">(Jan 09 2021 at 02:09)</a>:</h4>
<p>ok</p>



<a name="222165052"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222165052" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222165052">(Jan 09 2021 at 10:38)</a>:</h4>
<p>Hmm I just added boats' repo as a remote and created a branch tracking theirs PR branch</p>



<a name="222165391"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222165391" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222165391">(Jan 09 2021 at 10:46)</a>:</h4>
<p>I will push this branch to my fork then</p>



<a name="222165467"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222165467" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222165467">(Jan 09 2021 at 10:49)</a>:</h4>
<p>it is now pushed</p>



<a name="222165468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222165468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222165468">(Jan 09 2021 at 10:49)</a>:</h4>
<p><a href="https://github.com/JDuchniewicz/rust/commit/c655b81e8942ac0dd370618d324a308407b635dd">https://github.com/JDuchniewicz/rust/commit/c655b81e8942ac0dd370618d324a308407b635dd</a></p>



<a name="222165534"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222165534" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222165534">(Jan 09 2021 at 10:50)</a>:</h4>
<p>I could open a  PR to boats' repo now but I don't know if this is the way</p>



<a name="222165554"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222165554" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222165554">(Jan 09 2021 at 10:51)</a>:</h4>
<p>hence waiting for feedback and focusing on my other task in the meantime :)</p>



<a name="222172747"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222172747" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222172747">(Jan 09 2021 at 14:14)</a>:</h4>
<p>oh I should probably bump to 1.51</p>



<a name="222172764"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222172764" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222172764">(Jan 09 2021 at 14:15)</a>:</h4>
<p>like Ashley did in <a href="https://github.com/rust-lang/rust/pull/80553">here</a></p>



<a name="222174276"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222174276" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222174276">(Jan 09 2021 at 14:58)</a>:</h4>
<p><span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="222175339"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222175339" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222175339">(Jan 09 2021 at 15:28)</a>:</h4>
<p>still no permissions to force-push to boats' repo</p>



<a name="222180670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222180670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Ellis O&#x27;Riley Jr. <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222180670">(Jan 09 2021 at 17:47)</a>:</h4>
<p>Good afternoon.  After I create the people.toml file, how do I get it to the appropriate party?</p>



<a name="222180716"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222180716" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222180716">(Jan 09 2021 at 17:48)</a>:</h4>
<p><span class="user-mention" data-user-id="344328">@Charles Ellis O'Riley Jr.</span> Oh, there's no need</p>



<a name="222180724"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222180724" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222180724">(Jan 09 2021 at 17:48)</a>:</h4>
<p>I already made a people file for u</p>



<a name="222180736"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222180736" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Charles Ellis O&#x27;Riley Jr. <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222180736">(Jan 09 2021 at 17:48)</a>:</h4>
<p>Thank you.</p>



<a name="222181150"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222181150" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222181150">(Jan 09 2021 at 17:56)</a>:</h4>
<p>So not sure what to do next... I have the merge commits on my fork but I cannot add them to the PR (or can I?)</p>



<a name="222181509"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222181509" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222181509">(Jan 09 2021 at 18:03)</a>:</h4>
<p>I don't think you can, I'm working on it</p>



<a name="222181524"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222181524" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222181524">(Jan 09 2021 at 18:03)</a>:</h4>
<p>Ive already contacted boats, waiting on a reply</p>



<a name="222181528"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222181528" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222181528">(Jan 09 2021 at 18:03)</a>:</h4>
<p>We might need to make a new PR but let's not do that yet</p>



<a name="222181555"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222181555" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jane Lusby <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222181555">(Jan 09 2021 at 18:04)</a>:</h4>
<p>My hope is they'll just pull your code themselves</p>



<a name="222181914"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222181914" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222181914">(Jan 09 2021 at 18:11)</a>:</h4>
<p>ok, thank you for help!</p>



<a name="222554923"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222554923" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222554923">(Jan 13 2021 at 09:33)</a>:</h4>
<p>there is still some error, the <code>#![feature(backtrace)]</code>  attribute should be now removed from rustc_errors/src/lib.rs</p>



<a name="222555165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222555165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Ashley Mannix <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222555165">(Jan 13 2021 at 09:35)</a>:</h4>
<p><span aria-label="big smile" class="emoji emoji-1f604" role="img" title="big smile">:big_smile:</span> Well... Guess I’ll just keep pushing that branch then. I hope boats doesn’t mind me just coming along and poking around</p>



<a name="222709374"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222709374" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222709374">(Jan 14 2021 at 12:19)</a>:</h4>
<p>matklad suggested that <code>BacktraceStatus</code> be <code>Clone</code>able</p>



<a name="222709563"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/257204-project-error-handling/topic/fix%20the%20error%20trait%20PR%20finalization/near/222709563" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jakub Duchniewicz <a href="https://rust-lang.github.io/zulip_archive/stream/257204-project-error-handling/topic/fix.20the.20error.20trait.20PR.20finalization.html#222709563">(Jan 14 2021 at 12:22)</a>:</h4>
<p>looks sensible to me as all fields are simple</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>